-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change policy_id to list type in slm.get_lifecycle #47766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the REST API spec slm.get_lifecycle's polict_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values. Closes #47765
dakrone
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dakrone
added
the
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
label
Oct 10, 2019
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
@dakrone should this also be ported to |
@russcam yes, do you want me to do it or do you want to do it? |
@dakrone no worries, I got it. thanks! |
russcam
added a commit
that referenced
this pull request
Oct 24, 2019
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values. Closes #47765
russcam
added a commit
that referenced
this pull request
Oct 24, 2019
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values. Closes #47765
russcam
added a commit
that referenced
this pull request
Oct 24, 2019
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values. Closes #47765
24 tasks
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
v7.4.2
v7.5.0
v7.6.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the REST API spec slm.get_lifecycle's polict_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.
Closes #47765