Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow integer types for classification's dependent variable #47902

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Oct 11, 2019

Some users may want to encode their labels as booleans (true, false). Others may want to use integers (0, 1, 2, 3, etc.).
Classification API should allow for dependent variable being treated as categorical even if its type is boolean or discrete numeric.

Relates #46735

@przemekwitek przemekwitek force-pushed the support_numerical_dep_var branch 15 times, most recently from c673de8 to f389531 Compare October 15, 2019 13:48
@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/2

@przemekwitek przemekwitek force-pushed the support_numerical_dep_var branch 2 times, most recently from 48ef4e0 to e555d4c Compare October 15, 2019 15:04
@przemekwitek przemekwitek removed the WIP label Oct 15, 2019
@przemekwitek przemekwitek marked this pull request as ready for review October 15, 2019 15:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/packaging-sample-matrix

@przemekwitek przemekwitek force-pushed the support_numerical_dep_var branch from e555d4c to 7ba6ad2 Compare October 15, 2019 15:45
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants