-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow integer types for classification's dependent variable #47902
Merged
przemekwitek
merged 2 commits into
elastic:master
from
przemekwitek:support_numerical_dep_var
Oct 15, 2019
Merged
Allow integer types for classification's dependent variable #47902
przemekwitek
merged 2 commits into
elastic:master
from
przemekwitek:support_numerical_dep_var
Oct 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c673de8
to
f389531
Compare
run elasticsearch-ci/2 |
48ef4e0
to
e555d4c
Compare
Pinging @elastic/ml-core (:ml) |
run elasticsearch-ci/packaging-sample-matrix |
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/Types.java
Outdated
Show resolved
Hide resolved
e555d4c
to
7ba6ad2
Compare
dimitris-athanasiou
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Oct 15, 2019
przemekwitek
added a commit
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may want to encode their labels as booleans (true, false). Others may want to use integers (0, 1, 2, 3, etc.).
Classification API should allow for dependent variable being treated as categorical even if its type is boolean or discrete numeric.
Relates #46735