Do not reference values for filtered settings #48066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (:Core/Infra/Settings) |
|
Thanks, @rjernst. Any opinion on whether the same logic should be applied to typed settings such as int, float, date? |
|
Seems like it should apply to any settings marked as filtered, regardless of type. |
|
👍 I'll make the same changes for all the types, then. |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
|
@rjernst, my second commit on this PR removes any mention of values from validation errors on all typed settings with the |
rjernst
approved these changes
Oct 21, 2019
| Settings build = Settings.builder().put("foo.bar", "I am not a boolean").build(); | ||
| try { | ||
| settingUpdater.apply(build, Settings.EMPTY); | ||
| fail("not a boolean"); |
There was a problem hiding this comment.
Please use expectThrows instead of try/fail/catch
| try { | ||
| predicateSettingUpdater.apply(Settings.builder().put("foo.bar.1.value", "1").put("foo.bar.2.value", "2").build(), | ||
| Settings.EMPTY); | ||
| fail("not accepted"); |
|
@elasticmachine update branch |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 24, 2019
danhermann
added a commit
that referenced
this pull request
Oct 24, 2019
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 25, 2019
danhermann
added a commit
that referenced
this pull request
Oct 25, 2019
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 28, 2019
danhermann
added a commit
that referenced
this pull request
Oct 28, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation exceptions are often logged so the value of filtered properties (of any data type) shouldn't be included.