-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not prefix already prefixed format with 8 #48139
Conversation
It happens when a locale is specified on a mapping that a new JavaDateFormatter is created with a new mapping and already prefixed with 8 format is prefixed again. This should change avoids this behavior.
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
discovered with yml test failure #47983 |
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Just to double check: we would have never serialized multiple 8's right?
@elasticmachine run elasticsearch-ci/2 |
@rjernst good point, when serialising, it probably won't (I can't see how this could happen) |
It happens when a locale is specified on a mapping that a new
JavaDateFormatter is created with a new mapping and already prefixed
with 8 format is prefixed again. This should change avoids this
behavior.
gradle check
?