Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close query cache on index service creation failure #48278

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Close query cache on index service creation failure #48278

merged 2 commits into from
Oct 21, 2019

Conversation

DaveCTurner
Copy link
Contributor

Today it is possible that we create the QueryCache and then fail to create
the owning IndexService and this means we do not close the QueryCache
again. This commit addresses that leak.

Fixes #48186

@DaveCTurner
Close query cache on index service creation failure (elastic#48230)
d927b2a 
Today it is possible that we create the `QueryCache` and then fail to create
the owning `IndexService` and this means we do not close the `QueryCache`
again. This commit addresses that leak.

Fixes elastic#48186
@DaveCTurner DaveCTurner added >bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. backport v6.8.5 labels Oct 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CRUD)

@DaveCTurner
Copy link
Contributor Author

Transient network issues? Think this'll be fixed by #48249.

Step 4/29 : RUN curl -L --retry 8 -s https://github.com/AdoptOpenJDK/openjdk13-binaries/releases/download/jdk-13%2B33/OpenJDK13U-jdk_x64_linux_hotspot_13_33.tar.gz | tar -C /opt -zxf -
 ---> Running in 3b2ce113f6de
�[91m
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

@elasticmachine please run elasticsearch-ci/1

@DaveCTurner
Copy link
Contributor Author

Just™ a backport, no need for a review.

@DaveCTurner
Copy link
Contributor Author

Tests failed due to OOM

@elasticmachine please run elasticsearch-ci/2

@DaveCTurner DaveCTurner merged commit b82b3d6 into elastic:6.8 Oct 21, 2019
@DaveCTurner DaveCTurner deleted the 2019-10-21-backport-48230 branch October 21, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport >bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v6.8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveCTurner @elasticmachine