Ensure SLM stats does not block an in-place upgrade from 7.4 #48361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.5+ for SLM requires [stats] object to exist in the cluster state. When doing an in-place upgrade from 7.4 to 7.5+ [stats] does not exist in cluster state, result in an exception on startup [1]. This commit moves the [stats] to be an optional object in the parser and if not found will default to an empty stats object. [1] Caused by: java.lang.IllegalArgumentException: Required [stats]
jakelandis
added
>bug
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
|
hmm..failed to download ml artifact, trying again. @elasticmachine run elasticsearch-ci/bwc |
gwbrown
reviewed
Oct 22, 2019
Comment on lines
+448
to
+449
| client().performRequest(new Request("POST", "_ilm/stop")); | ||
| client().performRequest(new Request("POST", "_ilm/start")); |
There was a problem hiding this comment.
Because of #47710, we should PUT a policy here rather than starting/stopping.
Here's an example repository/policy you can PUT that will execute every February 31 (i.e. never):
PUT /_snapshot/test-repo
{
"type": "fs",
"settings": {
"location": "test-repo"
}
}
PUT /_slm/policy/test-policy
{
"schedule": "* * * 31 FEB ? *",
"name": "<test-snap-{now/d}>",
"repository": "test-repo",
"config": {
"indices": ["*"]
}
}
|
I realized this does indeed need to be targeted at 8.0/master first. So closing this PR in favor of #48367 |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5+ for SLM requires [stats] object to exist in the cluster state.
When doing an in-place upgrade from 7.4 to 7.5+ [stats] does not exist
in cluster state, result in an exception on startup [1].
This commit moves the [stats] to be an optional object in the parser
and if not found will default to an empty stats object.
[1] Caused by: java.lang.IllegalArgumentException: Required [stats]
Note - this is was not caught by normal full cluster state restart tests since by default there is no SLM data in cluster state. Stopping and restarting ILM is one way to force SLM cluster state to be written (hence the custom test)
Note - this does not need to merged to master/8.0, however, we may need a follow up PR in 7.x to ensure that SLM is eagerly written to cluster state.
Below is the full error when the test is run without the fix: