Refresh should not acquire readLock #48414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
|
A known issue tracked at #46021. @elasticmachine run elasticsearch-ci/1 |
There was a problem hiding this comment.
This looks good to me, but not sure that counts for this issue. I did try to find a hole in the plot (and were unable to), but the other reviewers have the necessary historic background to do a qualified review.
Maybe also add a test to demonstrate that we do not hold the lock?
jpountz
approved these changes
Oct 24, 2019
+1. I added that test in 37e1558. |
ywelsch
approved these changes
Oct 25, 2019
|
@henningandersen @jpountz @ywelsch Thanks for reviewing. |
dnhatn
added a commit
that referenced
this pull request
Oct 25, 2019
Today, we hold the engine readLock while refreshing. Although this choice simplifies the correctness reasoning, it can block IndexShard from closing if warming an external reader takes time. The current implementation of refresh does not need to hold readLock as ReferenceManager can handle errors correctly if the engine is closed in midway. This PR is a prerequisite that we need to solve #47186.
+1 |
dnhatn
added a commit
that referenced
this pull request
Nov 3, 2019
Today, we hold the engine readLock while refreshing. Although this choice simplifies the correctness reasoning, it can block IndexShard from closing if warming an external reader takes time. The current implementation of refresh does not need to hold readLock as ReferenceManager can handle errors correctly if the engine is closed in midway. This PR is a prerequisite that we need to solve #47186.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we hold the engine readLock while refreshing. Although this choice simplifies the correctness reasoning, it can block IndexShard from closing if warming an external reader takes time. The current implementation of refresh does not need to hold readLock as ReferenceManager can handle errors correctly if the engine is closed in midway.
This PR is a prerequisite that we need to solve #47186.
Relates #47186