Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 28, 2019

This PR adds content from https://github.com/elastic/ml-cpp/blob/7.4/docs/CHANGELOG.asciidoc to the 7.4.1 release notes. It also edits the list of PRs and removes a PR that was incorrectly listed as an issue.

@lcawl lcawl added >docs General docs changes :ml Machine learning v7.5.0 v7.6.0 v7.4.2 labels Oct 28, 2019
@lcawl lcawl requested a review from droberts195 October 28, 2019 19:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

* [Transform] prevent assignment to nodes older than 7.4 {pull}48044[#48044] (issue: {issue}48019[#48019])
* [ML][Transforms] fix bwc serialization with 7.3 {pull}48021[#48021]
* Prevent assignment if any node is older than 7.4 {pull}48055[#48055] (issue: {issue}48019[#48019])
* Prevent assignment to nodes older than 7.4 {pull}48044[#48044] (issue: {issue}48019[#48019])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should document this one because it says "superseded by #48055" (which is already documented in the line above).

* Fix detection of syslog-like timestamp in find_file_structure {pull}47970[#47970]
* Reinstate ML daily maintenance actions {pull}47103[#47103] (issue: {issue}47003[#47003])
* A reference to a temporary variable was causing forecast model restoration to
fail. The bug exhibited itself on MacOS builds with versions of clangd > 10.0.0. {ml-pull}688[#688]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an end user perspective this one should have been something more like:

The thing about clang 10+ refers to how it was reproducible in the unit tests. The fix was for undefined behaviour so the bug could affect the production code differently.

Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit c6f4662 into elastic:7.x Oct 29, 2019
@lcawl lcawl deleted the 7x-ml-rn branch October 29, 2019 16:35
@polyfractal polyfractal added v7.4.3 and removed v7.4.2 labels Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :ml Machine learning v7.4.3 v7.5.0 v7.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants