Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IndexLifecycleExplainResponse serialization version checks #48754

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Fix IndexLifecycleExplainResponse serialization version checks #48754

merged 1 commit into from
Oct 31, 2019

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Oct 31, 2019

This fixes the version checks to use 7.6.0 instead of 8.0.0 since the
changes in #48256 were backported to the 7.x branch.

@dakrone
Fix IndexLifecycleExplainResponse serialization version checks
44be516 
This fixes the version checks to use 7.6.0 instead of 8.0.0 since the
changes in elastic#48256 were backported to the 7.x branch.
@dakrone dakrone added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 labels Oct 31, 2019
@dakrone dakrone requested review from andreidan and gwbrown October 31, 2019 14:03
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

andreidan
andreidan approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gwbrown
gwbrown approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Serialization is hard.

@andreidan andreidan mentioned this pull request Oct 31, 2019
Closed
@andreidan
Copy link
Contributor

Thanks for fixing this @dakrone

@dakrone
Copy link
Member Author

dakrone commented Oct 31, 2019

@elasticmachine run elasticsearch-ci/2
@elasticmachine run elasticsearch-ci/packaging-sample-matrix

I opened #48767 for the failure

@dakrone dakrone merged commit 95ee5b1 into elastic:master Oct 31, 2019
@dakrone dakrone deleted the slm-fix-bwc-version-checks branch October 31, 2019 18:01
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Oct 31, 2019
@dakrone
Unmute mixed_cluster/70_ilm/Test Set Policy On Index
ea06875 
This was fixed by elastic#48754

Revert "Muted 'mixed_cluster/70_ilm/Test Set Policy On Index' test"

This reverts commit ef22ddb.

Resolves elastic#48749
@dakrone dakrone mentioned this pull request Oct 31, 2019
Merged
dakrone added a commit that referenced this pull request Oct 31, 2019
@dakrone
Unmute mixed_cluster/70_ilm/Test Set Policy On Index (#48769)
2179dfa 
This was fixed by #48754

Revert "Muted 'mixed_cluster/70_ilm/Test Set Policy On Index' test"

This reverts commit ef22ddb.

Resolves #48749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreidan andreidan andreidan approved these changes

@gwbrown gwbrown gwbrown approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dakrone @elasticmachine @andreidan @gwbrown @jakelandis