Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop NodeTests from timing out in certain cases #49202

Merged
merged 4 commits into from
Nov 22, 2019

Commits on Nov 15, 2019

  1. Stop NodeTests from timing out in certain cases

    The NodeTests class contains tests that check behavior when shutting
    down a node. This involves starting a node, performing some operation,
    stopping the node, and then awaiting the close of the node. Part of
    closing a node is the termination of the node's ThreadPool. ThreadPool
    termination semantics can be deceiving. The ThreadPool#terminate method
    takes a timeout value and the first oddity is that the terminate method
    can take two times the timeout value before returning. Internally this
    method acts on the ExecutorService instances that are held by the
    ThreadPool. First, an orderly shutdown is attempted and pending tasks
    are allowed to execute while waiting for the timeout value. If any of
    the ExecutorService instances have not terminated, a call is made to
    attempt to stop all active tasks (usually using interrupts) and then
    waits for up to the timeout value a second time for the termination of
    the ExecutorService instances. This means that if use a large value
    when waiting for a node to close, we may not attempt to interrupt any
    threads that are in a blocking call before the test times out.
    
    In order to avoid causing these tests to time out, this change reduces
    the timeout passed to Node#awaitClose to 10 seconds from 1 day. This
    will allow blocked threads to be interrupted before the test suite
    fails due to the timeout.
    
    Closes elastic#44256
    Closes elastic#42350
    jaymode committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    c145c95 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Configuration menu
    Copy the full SHA
    005d856 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Configuration menu
    Copy the full SHA
    cf7268c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Configuration menu
    Copy the full SHA
    468c64a View commit details
    Browse the repository at this point in the history