-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Added missing methods to enrich and slm endpoints #49233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
|
and/or REST pedantry (which is kind of already out the window considering our main API is a GET with a body). I'm conflicted on this one. We should definitely encourage the use of |
Local patch for implementation in elastic/elasticsearch#47061 and subsequent PR elastic/elasticsearch#49233
| { | ||
| "path": "/_enrich/policy/{name}/_execute", | ||
| "methods": [ "PUT" ], | ||
| "methods": [ "PUT", "POST" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "methods": [ "PUT", "POST" ], | |
| "methods": [ "POST", "PUT" ], |
SInce POST is preferred list it first.
|
Clients take the listed http methods in order of preference so listing POST before PUT would go along way already. |
…4246) Local patch for implementation in elastic/elasticsearch#47061 and subsequent PR elastic/elasticsearch#49233
Hello!
In the spec both
/_slm/policy/{name}/_executeand/_enrich/policy/{name}/_executedeclarePUTas the only method supported, but in the codePOSTis supported as well.elasticsearch/x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/slm/action/RestExecuteSnapshotLifecycleAction.java
Lines 18 to 21 in b42923f
elasticsearch/x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/rest/RestExecuteEnrichPolicyAction.java
Lines 19 to 22 in f914172
cc @elastic/es-clients