Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadPool and ThreadContext are not closeable (#43249) #49273

Merged
merged 3 commits into from
Nov 19, 2019

Commits on Nov 18, 2019

  1. ThreadPool and ThreadContext are not closeable (elastic#43249)

    This commit changes the ThreadContext to just use a regular ThreadLocal
    over the lucene CloseableThreadLocal. The CloseableThreadLocal solves
    issues with ThreadLocals that are no longer needed during runtime but
    in the case of the ThreadContext, we need it for the runtime of the
    node and it is typically not closed until the node closes, so we miss
    out on the benefits that this class provides.
    
    Additionally by removing the close logic, we simplify code in other
    places that deal with exceptions and tracking to see if it happens when
    the node is closing.
    
    Closes elastic#42577
    jaymode committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    1cdf795 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Configuration menu
    Copy the full SHA
    b3f9fb7 View commit details
    Browse the repository at this point in the history
  2. unused import

    jaymode committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    d954d39 View commit details
    Browse the repository at this point in the history