Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ClassInfo interface and BinaryClassInfo class. #49649

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Remove ClassInfo interface and BinaryClassInfo class. #49649

merged 3 commits into from
Nov 28, 2019

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Nov 27, 2019 •
edited
Loading

Several cleanups in evaluation server-side code:

  • Remove ClassInfo interface and BinaryClassInfo class. This class was meant to provide support for multiple classes but such a functionality is not currently needed and the code becomes simpler without it.
  • Move the aggs and process methods to EvaluationMetric interface
  • Move the common code from Evaluation's subclasses to the interface

Related to #48759

@przemekwitek przemekwitek marked this pull request as ready for review November 27, 2019 15:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/default-distro

1 similar comment
@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/default-distro

dimitris-athanasiou
dimitris-athanasiou reviewed Nov 28, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good stuff in this one! My two code comments are very minor and on points you didn't introduce now but it was already in the existing code.

...ugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/Evaluation.java Outdated Show resolved Hide resolved
...ugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/Evaluation.java Outdated Show resolved Hide resolved
dimitris-athanasiou
dimitris-athanasiou approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit e248610 into elastic:master Nov 28, 2019
@przemekwitek przemekwitek deleted the refactor_evaluation_interfaces branch November 28, 2019 12:03
@przemekwitek przemekwitek mentioned this pull request Nov 28, 2019
Merged
przemekwitek added a commit that referenced this pull request Nov 28, 2019
@przemekwitek
[7.x] Remove ClassInfo interface and BinaryClassInfo class. (#49649) (#…
1425e30 
…49681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
:ml Machine learning >refactoring v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@przemekwitek @elasticmachine @dimitris-athanasiou @jakelandis