Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for remaining IntervalsSourceProvider implementations #50326

Merged
merged 9 commits into from
Jan 6, 2020
Merged

Add tests for remaining IntervalsSourceProvider implementations #50326

merged 9 commits into from
Jan 6, 2020

Conversation

Hohol
Copy link
Contributor

@Hohol Hohol commented Dec 18, 2019

This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider implementations.

Closes #50150

@Hohol
Copy link
Contributor Author

Hohol commented Dec 18, 2019

@cbuescher there turned out to be a lot of dependencies between tests, because remaining providers may be nested and so are naturally dependent on each other. So I thought it would be better to add these tests as a single PR.

@jtibshirani jtibshirani added :Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests labels Dec 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@Hohol
Merge branch 'master' into isp-tests
ac977f9 
# Conflicts:
#	server/src/test/java/org/elasticsearch/index/query/IntervalQueryBuilderTests.java
@Hohol
Copy link
Contributor Author

Hohol commented Dec 23, 2019

@cbuescher, can you review this, please?

cbuescher
cbuescher approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @Hohol, thanks again for adding these tests. I left some very minor nit-picks, the rest LGTM. I will already run a round of tests even though you might want to add another commit just to see if there are unrelated test issues in this branch.

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher self-assigned this Jan 2, 2020
@cbuescher
Copy link
Member

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@cbuescher
Copy link
Member

@Hohol Looks like there's a new Fuzzy IntervalsSourceProvider that was just added via #49762 which create a conflict for the changes in SearchModule. I can resolve them, but maybe you want to add that class to the testing anyway with this PR. Can of course also be done as a follow up, only the conflict needs to be resolved.

@Hohol
Copy link
Contributor Author

Hohol commented Jan 4, 2020 •
edited
Loading

I've added a test for Fuzzy Provider.

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit dfc308a into elastic:master Jan 6, 2020
cbuescher pushed a commit that referenced this pull request Jan 6, 2020
@Hohol
Add tests for remaining IntervalsSourceProvider implementations (#50326)
5533e11 
This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider
implementations.

Closes #50150
@cbuescher
Copy link
Member

Thanks again @Hohol for working on this, great to have these tests in place now. I merged to master and the 7.6 branch.

@Hohol Hohol deleted the isp-tests branch January 6, 2020 12:34
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@Hohol @SivagurunathanV
Add tests for remaining IntervalsSourceProvider implementations (elas…
ed50a37 
…tic#50326)

This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider
implementations.

Closes elastic#50150
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees

@cbuescher cbuescher

Labels
:Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for IntervalsSourceProvider implementations
5 participants
@Hohol @elasticmachine @cbuescher @jakelandis @jtibshirani