Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Unknown scripting annotations raise error #50343

Conversation

stu-elastic
Copy link
Contributor

Ensure that unknown annotations, such as typo'd @nondeterministic, will raise an exception.

@stu-elastic stu-elastic added >test Issues or PRs that are addressing/adding tests :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 v7.6.0 labels Dec 18, 2019
@stu-elastic stu-elastic requested a review from jdconrad December 18, 2019 22:17
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding these tests.

@stu-elastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/2

@stu-elastic stu-elastic merged commit b92b91a into elastic:master Dec 18, 2019
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this pull request Dec 18, 2019
Ensure that unknown annotations, such as typo'd `@nondeterministic`, 
will raise an exception.
stu-elastic added a commit that referenced this pull request Dec 19, 2019
Ensure that unknown annotations, such as typo'd `@nondeterministic`, 
will raise an exception.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Ensure that unknown annotations, such as typo'd `@nondeterministic`, 
will raise an exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >test Issues or PRs that are addressing/adding tests v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants