Refactor GeoShape tests to GeoShape and GeoPoint #50737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
November 15, 2019 19:05
in Class org.elasticsearch.search.geo.GeoPointShapeQueryTests
…tion raised, see org.elasticsearch.index.query.QueryShardContext.toQuery
in GeoPointShapeQueryTests
…ShapeQueryTests.java
dliappis
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
iverase
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
iverase
requested changes
Jan 9, 2020
server/src/test/java/org/elasticsearch/search/geo/GeoPointShapeQueryTests.java
Show resolved
Hide resolved
|
That is looking good. Could you resolve conflicts some can see if test passes. |
added 3 commits
January 24, 2020 14:31
GeoShapeQueryTests refactored adding superclass and sibling to accomodate new test coverage as part of adaptation of geo_shape query to work on geo_point fields
|
@elasticmachine run elasticsearch-ci/2 |
djptek
added a commit
to djptek-legacy/elasticsearch
that referenced
this pull request
Jan 30, 2020
djptek
added a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of GeoShape tests to separate GeoShape and GeoPoint as preliminary step prior to implementing #48928
Added new methods to avoid duplicate code for mapping creation
All existing tests passed post refactor in org.elasticsearch.search.geo.*
New placeholder test in GeoPointShapeQueryTests is non-failing pending 48928
Note commit 24b9535 has been reset by d7f2218 this will be reincorporated as part of 48928