Migrate certgen packaging test from bats #50880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the packaging tests for elasticsearch-certgen to java from bats. Although certgen is deprecated, the tests are moved rather than just deleted, and the tests themselves should be easily adaptable to certutil. One note is that the test is simplified to use a single node, rather than the two node test from bats, which was problematic given how the newer distro tests only operate with a single distribution. relates elastic#46005
rjernst
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
pugnascotia
reviewed
Jan 13, 2020
| public static String escapePath(Path path) { | ||
| if (Platforms.WINDOWS) { | ||
| // replace single backslash with forward slash. note the first string is a regex, so is double escaped | ||
| return path.toString().replaceAll("\\\\", "/"); |
There was a problem hiding this comment.
You could just do:
Suggested change
| return path.toString().replaceAll("\\\\", "/"); | |
| return path.toString().replace('\\', '/'); |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jan 13, 2020
This commit moves the packaging tests for elasticsearch-certgen to java from bats. Although certgen is deprecated, the tests are moved rather than just deleted, and the tests themselves should be easily adaptable to certutil. One note is that the test is simplified to use a single node, rather than the two node test from bats, which was problematic given how the newer distro tests only operate with a single distribution. relates elastic#46005
rjernst
added a commit
that referenced
this pull request
Jan 13, 2020
This commit moves the packaging tests for elasticsearch-certgen to java from bats. Although certgen is deprecated, the tests are moved rather than just deleted, and the tests themselves should be easily adaptable to certutil. One note is that the test is simplified to use a single node, rather than the two node test from bats, which was problematic given how the newer distro tests only operate with a single distribution. relates #46005
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This commit moves the packaging tests for elasticsearch-certgen to java from bats. Although certgen is deprecated, the tests are moved rather than just deleted, and the tests themselves should be easily adaptable to certutil. One note is that the test is simplified to use a single node, rather than the two node test from bats, which was problematic given how the newer distro tests only operate with a single distribution. relates elastic#46005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the packaging tests for elasticsearch-certgen
to java from bats. Although certgen is deprecated, the tests are
moved rather than just deleted, and the tests themselves should be
easily adaptable to certutil. One note is that the test is simplified to
use a single node, rather than the two node test from bats, which was
problematic given how the newer distro tests only operate with a single
distribution.
relates #46005