Skip to content

Cleanup default values source type #50992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-napoleon merged 8 commits into from
Jan 21, 2020
Merged

Cleanup default values source type #50992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
66c4f47
Remove unused script param from defaultValuesSourceType
not-napoleon Jan 14, 2020
69f9018
Make defaultValuesSourceType abstract
not-napoleon Jan 14, 2020
89268d2
missed a couple
not-napoleon Jan 14, 2020
dc6da95
hopefully the last hidden VSAB subclass
not-napoleon Jan 15, 2020
1942c69
Merge branch 'feature/extensible-values-source' into cleanup-defaultV…
not-napoleon Jan 16, 2020
aef4888
Merge branch 'feature/extensible-values-source' into cleanup-defaultV…
not-napoleon Jan 16, 2020
3ed260a
Correct default type for GeoGrid aggs
not-napoleon Jan 16, 2020
4d776fe
fix checkstyle
not-napoleon Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...nt-join/src/main/java/org/elasticsearch/join/aggregations/ChildrenAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand Down Expand Up @@ -74,6 +75,11 @@ protected ChildrenAggregationBuilder(ChildrenAggregationBuilder clone,
this.parentFilter = clone.parentFilter;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new ChildrenAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
6 changes: 6 additions & 0 deletions ...rent-join/src/main/java/org/elasticsearch/join/aggregations/ParentAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand Down Expand Up @@ -74,6 +75,11 @@ protected ParentAggregationBuilder(ParentAggregationBuilder clone,
this.parentFilter = clone.parentFilter;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new ParentAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
7 changes: 7 additions & 0 deletions .../java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,12 @@
import org.elasticsearch.search.aggregations.AggregatorFactory;
import org.elasticsearch.search.aggregations.bucket.BucketUtils;
import org.elasticsearch.search.aggregations.bucket.MultiBucketAggregationBuilder;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand Down Expand Up @@ -100,6 +102,11 @@ public GeoGridAggregationBuilder(StreamInput in) throws IOException {
}
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.GEOPOINT;
}

@Override
protected void innerWriteTo(StreamOutput out) throws IOException {
out.writeVInt(precision);
Expand Down
8 changes: 8 additions & 0 deletions ...asticsearch/search/aggregations/bucket/histogram/AutoDateHistogramAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,12 @@
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
import org.elasticsearch.search.aggregations.MultiBucketConsumerService;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.time.ZoneId;
Expand Down Expand Up @@ -149,6 +151,12 @@ protected AutoDateHistogramAggregationBuilder(AutoDateHistogramAggregationBuilde
this.minimumIntervalExpression = clone.minimumIntervalExpression;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
// TODO: This should probably be DATE, but we're not failing tests with BYTES, so needs more tests?
Copy link
Contributor

@polyfractal polyfractal Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new AutoDateHistogramAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
5 changes: 2 additions & 3 deletions ...g/elasticsearch/search/aggregations/bucket/histogram/DateHistogramAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import org.elasticsearch.index.mapper.MappedFieldType;
import org.elasticsearch.index.mapper.MappedFieldType.Relation;
import org.elasticsearch.index.query.QueryShardContext;
import org.elasticsearch.script.Script;
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
Expand Down Expand Up @@ -160,7 +159,7 @@ public DateHistogramAggregationBuilder(StreamInput in) throws IOException {
}

@Override
protected ValuesSourceType defaultValueSourceType(Script script) {
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.DATE;
}

Expand Down Expand Up @@ -283,7 +282,7 @@ public DateHistogramAggregationBuilder offset(String offset) {
}

/**
* Parse the string specification of an offset.
* Parse the string specification of an offset.
*/
public static long parseStringOffset(String offset) {
if (offset.charAt(0) == '-') {
Expand Down
3 changes: 1 addition & 2 deletions ...a/org/elasticsearch/search/aggregations/bucket/histogram/HistogramAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentParser;
import org.elasticsearch.index.query.QueryShardContext;
import org.elasticsearch.script.Script;
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
Expand Down Expand Up @@ -105,7 +104,7 @@ public static void registerAggregators(ValuesSourceRegistry valuesSourceRegistry
private long minDocCount = 0;

@Override
protected ValuesSourceType defaultValueSourceType(Script script) {
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.NUMERIC;
}

Expand Down
7 changes: 7 additions & 0 deletions .../java/org/elasticsearch/search/aggregations/bucket/missing/MissingAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand All @@ -58,6 +60,11 @@ protected MissingAggregationBuilder(MissingAggregationBuilder clone, Builder fac
super(clone, factoriesBuilder, metaData);
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new MissingAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
3 changes: 1 addition & 2 deletions ...rc/main/java/org/elasticsearch/search/aggregations/bucket/range/AbstractRangeBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.elasticsearch.common.io.stream.StreamOutput;
import org.elasticsearch.common.io.stream.Writeable;
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.script.Script;
import org.elasticsearch.search.aggregations.AggregatorFactories;
import org.elasticsearch.search.aggregations.bucket.MultiBucketAggregationBuilder;
import org.elasticsearch.search.aggregations.bucket.range.RangeAggregator.Range;
Expand Down Expand Up @@ -70,7 +69,7 @@ protected AbstractRangeBuilder(StreamInput in, InternalRange.Factory<?, ?> range
}

@Override
protected ValuesSourceType defaultValueSourceType(Script script) {
protected ValuesSourceType defaultValueSourceType() {
// Copied over from the old targetValueType setting. Not sure what cases this is still relevant for. --Tozzi 2020-01-13
return rangeFactory.getValueSourceType();
}
Expand Down
3 changes: 1 addition & 2 deletions .../java/org/elasticsearch/search/aggregations/bucket/range/DateRangeAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.elasticsearch.common.xcontent.ObjectParser;
import org.elasticsearch.common.xcontent.XContentParser;
import org.elasticsearch.index.query.QueryShardContext;
import org.elasticsearch.script.Script;
import org.elasticsearch.search.DocValueFormat;
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
Expand Down Expand Up @@ -87,7 +86,7 @@ public String getType() {
}

@Override
protected ValuesSourceType defaultValueSourceType(Script script) {
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.DATE;
}

Expand Down
10 changes: 9 additions & 1 deletion ...ava/org/elasticsearch/search/aggregations/bucket/range/GeoDistanceAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.ArrayList;
Expand Down Expand Up @@ -233,7 +235,6 @@ private GeoDistanceAggregationBuilder(String name, GeoPoint origin,
this.origin = origin;
}

// TODO: this should set defaultValuesSourceType to GEOPOINT

/**
* Read from a stream.
Expand Down Expand Up @@ -265,6 +266,13 @@ protected GeoDistanceAggregationBuilder(GeoDistanceAggregationBuilder clone, Bui
this.ranges = new ArrayList<>(clone.ranges);
}

@Override
protected ValuesSourceType defaultValueSourceType() {
// TODO: This should probably not be BYTES, but we're not failing tests with BYTES, so needs more tests?
// TODO: this should set defaultValuesSourceType to GEOPOINT
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new GeoDistanceAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
2 changes: 1 addition & 1 deletion ...in/java/org/elasticsearch/search/aggregations/bucket/range/IpRangeAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public IpRangeAggregationBuilder(StreamInput in) throws IOException {
}

@Override
protected ValuesSourceType defaultValueSourceType(Script script) {
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.IP;
}

Expand Down
7 changes: 7 additions & 0 deletions ...a/org/elasticsearch/search/aggregations/bucket/sampler/DiversifiedAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand Down Expand Up @@ -70,6 +72,11 @@ protected DiversifiedAggregationBuilder(DiversifiedAggregationBuilder clone, Bui
this.executionHint = clone.executionHint;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new DiversifiedAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
7 changes: 7 additions & 0 deletions ...sticsearch/search/aggregations/bucket/significant/SignificantTermsAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@
import org.elasticsearch.search.aggregations.bucket.terms.TermsAggregationBuilder;
import org.elasticsearch.search.aggregations.bucket.terms.TermsAggregator;
import org.elasticsearch.search.aggregations.bucket.terms.TermsAggregator.BucketCountThresholds;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand Down Expand Up @@ -123,6 +125,11 @@ protected SignificantTermsAggregationBuilder(SignificantTermsAggregationBuilder
this.significanceHeuristic = clone.significanceHeuristic;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new SignificantTermsAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
7 changes: 7 additions & 0 deletions .../java/org/elasticsearch/search/aggregations/bucket/terms/RareTermsAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand Down Expand Up @@ -77,6 +79,11 @@ private RareTermsAggregationBuilder(RareTermsAggregationBuilder clone, Builder f
this.includeExclude = clone.includeExclude;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new RareTermsAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
7 changes: 7 additions & 0 deletions ...main/java/org/elasticsearch/search/aggregations/bucket/terms/TermsAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@
import org.elasticsearch.search.aggregations.InternalOrder.CompoundOrder;
import org.elasticsearch.search.aggregations.bucket.MultiBucketAggregationBuilder;
import org.elasticsearch.search.aggregations.bucket.terms.TermsAggregator.BucketCountThresholds;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregatorFactory;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.List;
Expand Down Expand Up @@ -120,6 +122,11 @@ protected TermsAggregationBuilder(TermsAggregationBuilder clone, Builder factori
this.showTermDocCountError = clone.showTermDocCountError;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

@Override
protected AggregationBuilder shallowCopy(Builder factoriesBuilder, Map<String, Object> metaData) {
return new TermsAggregationBuilder(this, factoriesBuilder, metaData);
Expand Down
3 changes: 1 addition & 2 deletions ...er/src/main/java/org/elasticsearch/search/aggregations/metrics/AvgAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentParser;
import org.elasticsearch.index.query.QueryShardContext;
import org.elasticsearch.script.Script;
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
Expand Down Expand Up @@ -60,7 +59,7 @@ public AvgAggregationBuilder(AvgAggregationBuilder clone, Builder factoriesBuild
}

@Override
protected ValuesSourceType defaultValueSourceType(Script script) {
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.NUMERIC;
}

Expand Down
7 changes: 7 additions & 0 deletions ...ain/java/org/elasticsearch/search/aggregations/metrics/CardinalityAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
import org.elasticsearch.search.aggregations.support.CoreValuesSourceType;
import org.elasticsearch.search.aggregations.support.ValuesSource;
import org.elasticsearch.search.aggregations.support.ValuesSourceAggregationBuilder;
import org.elasticsearch.search.aggregations.support.ValuesSourceConfig;
import org.elasticsearch.search.aggregations.support.ValuesSourceParserHelper;
import org.elasticsearch.search.aggregations.support.ValuesSourceType;

import java.io.IOException;
import java.util.Map;
Expand Down Expand Up @@ -70,6 +72,11 @@ public CardinalityAggregationBuilder(CardinalityAggregationBuilder clone, Builde
this.precisionThreshold = clone.precisionThreshold;
}

@Override
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.BYTES;
}

/**
* Read from a stream.
*/
Expand Down
3 changes: 1 addition & 2 deletions ...n/java/org/elasticsearch/search/aggregations/metrics/ExtendedStatsAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentParser;
import org.elasticsearch.index.query.QueryShardContext;
import org.elasticsearch.script.Script;
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregatorFactories.Builder;
import org.elasticsearch.search.aggregations.AggregatorFactory;
Expand Down Expand Up @@ -81,7 +80,7 @@ public ExtendedStatsAggregationBuilder(StreamInput in) throws IOException {
}

@Override
protected ValuesSourceType defaultValueSourceType(Script script) {
protected ValuesSourceType defaultValueSourceType() {
return CoreValuesSourceType.NUMERIC;
}

Expand Down
Loading