Migrate SysV init tests from bats to java packaging #51077
Conversation
This commit converts the sysv init tests from bats tests into the java packaging tests. Since it is the last oss specific test, the bats oss test task is also removed. relates elastic#46005
rjernst
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
| public static void filterDistros() { | ||
| assumeTrue("rpm or deb", distribution.isPackage()); | ||
| assumeTrue(Platforms.isSysVInit()); | ||
| assumeTrue(Platforms.isSystemd()); |
There was a problem hiding this comment.
Why do we need this check?
There was a problem hiding this comment.
It actually should be assumeFalse. This is necessary because some systems have both sysv init and systemd, where sysv commands are a thin layer over systemd. This assume is meant to ensure we only test on systems with true sysv init support. Without it the tests will fail as we are testing behavior specifically in our init.d script, which would not be run in the hybrid systems.
| sh.run("service elasticsearch stop"); | ||
| } | ||
|
|
||
| public void assertStatus(int code, String msg) { |
There was a problem hiding this comment.
Leftover from a previous iteration. Removed.
|
|
||
| @Override | ||
| public void startElasticsearch() throws Exception { | ||
| // since some systems have both sysv and systemd, we need to be explicit here to use sysv |
There was a problem hiding this comment.
I looks like we skip this when systemd is around.
There was a problem hiding this comment.
Indeed this comment is out of date. I do like being more epxlicit here and using the service calls directly , rather than relying on the parent class to decide to use sysv.
This commit converts the sysv init tests from bats tests into the java packaging tests. Since it is the last oss specific test, the bats oss test task is also removed. relates elastic#46005
This commit converts the sysv init tests from bats tests into the java
packaging tests. Since it is the last oss specific test, the bats oss
test task is also removed.
relates #46005