[ML] Validate classification dependent_variable cardinality is at lea… #51232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
approved these changes
Jan 20, 2020
| @@ -37,9 +37,9 @@ | |||
| List<RequiredField> getRequiredFields(); | |||
|
|
|||
| /** | |||
| * @return {@link Map} containing cardinality limits for the selected (analysis-specific) fields | |||
| * @return {@link List} containing cardinality limits for the selected (analysis-specific) fields | |||
There was a problem hiding this comment.
s/limits/constraints
?
| */ | ||
| Map<String, Long> getFieldCardinalityLimits(); | ||
| List<FieldCardinalityConstraint> getFieldCardinalityLimits(); |
There was a problem hiding this comment.
s/Limits/Constraints
?
| @@ -89,7 +89,7 @@ public void testRequiredFieldsIsEmpty() { | |||
| } | |||
|
|
|||
| public void testFieldCardinalityLimitsIsEmpty() { | |||
| assertThat(createTestInstance().getFieldCardinalityLimits(), is(anEmptyMap())); | |||
| assertThat(createTestInstance().getFieldCardinalityLimits().isEmpty(), is(true)); | |||
There was a problem hiding this comment.
There is a "Matchers.empty()" matcher that could be used here.
| @@ -106,7 +106,7 @@ public void testRequiredFieldsIsNonEmpty() { | |||
| } | |||
|
|
|||
| public void testFieldCardinalityLimitsIsEmpty() { | |||
| assertThat(createTestInstance().getFieldCardinalityLimits(), is(anEmptyMap())); | |||
| assertThat(createTestInstance().getFieldCardinalityLimits().isEmpty(), is(true)); | |||
There was a problem hiding this comment.
There is a "Matchers.empty()" matcher that could be used here.
| @@ -177,6 +177,7 @@ private void reindexDataframeAndStartAnalysis(DataFrameAnalyticsTask task, DataF | |||
| ActionListener<CreateIndexResponse> copyIndexCreatedListener = ActionListener.wrap( | |||
| createIndexResponse -> { | |||
| ReindexRequest reindexRequest = new ReindexRequest(); | |||
| reindexRequest.setRefresh(true); | |||
There was a problem hiding this comment.
Note that this is now necessary as we are checking the field cardinality before we call startAnalytics which refreshes the dest index.
|
@przemekwitek I have addressed all your points plus fixes a bug regarding refreshing of the dest index which was caught by the tests. |
przemekwitek
approved these changes
Jan 21, 2020
| @@ -492,7 +492,7 @@ private void initialize(String jobId) { | |||
| this.jobId = jobId; | |||
| this.sourceIndex = jobId + "_source_index"; | |||
| this.destIndex = sourceIndex + "_results"; | |||
| this.analysisUsesExistingDestIndex = randomBoolean(); | |||
| this.analysisUsesExistingDestIndex = false; | |||
There was a problem hiding this comment.
Should this be reverted?
There was a problem hiding this comment.
Ah, yes of course.
Please see my comment in |
…st two Data frame analytics classification currently only supports 2 classes for the dependent variable. We were checking that the field's cardinality is not higher than 2 but we should also check it is not less than that as otherwise the process fails.
dimitris-athanasiou
force-pushed
the
validate-classification-dep-var-cardinality-at-least-two
branch
from
e51393e to
eab85d5
Compare
dimitris-athanasiou
deleted the
validate-classification-dep-var-cardinality-at-least-two
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jan 22, 2020
…t lea… (elastic#51232) Data frame analytics classification currently only supports 2 classes for the dependent variable. We were checking that the field's cardinality is not higher than 2 but we should also check it is not less than that as otherwise the process fails. Backport of elastic#51232
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jan 22, 2020
…t lea… (elastic#51232) Data frame analytics classification currently only supports 2 classes for the dependent variable. We were checking that the field's cardinality is not higher than 2 but we should also check it is not less than that as otherwise the process fails. Backport of elastic#51232
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st two
Data frame analytics classification currently only supports 2 classes for the
dependent variable. We were checking that the field's cardinality is not higher
than 2 but we should also check it is not less than that as otherwise the process
fails.