Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM _retry skips non-managed indices #51339

Closed
wants to merge 5 commits into from

Conversation

probakowski
Copy link
Contributor

This change makes _retry ILM endpoint to skip indices that are not
managed by the ILM (i.e. don't have ILM metadata stored) instead of
throwing exception.
This allows user to call */_ilm/retry and the request won't fail
because of unmanaged indices (for example .monitoring-kibana-*)

Closes #44188

This change makes `_retry` ILM endpoint to skip indices that are not
managed by the ILM (i.e. don't have ILM metadata stored) instead of
throwing exception.
This allows user to call `*/_ilm/retry` and the request won't fail
because of unmanaged indices (for example .monitoring-kibana-*)

Closes elastic#44188
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this, it's a small thing that will be very nice. Could you add a small test for the functionality also?

@bpintea bpintea added v7.8.0 and removed v7.7.0 labels Mar 25, 2020
@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@joegallo joegallo self-assigned this Sep 29, 2020
@andreidan andreidan added v7.11.0 and removed v7.10.0 labels Oct 7, 2020
@joegallo
Copy link
Contributor

I merged master into this PR to resolve the conflicts. I'll take a look through things and re-review with @dakrone next week, and we'll see about getting this over the line.

@joegallo
Copy link
Contributor

@dakrone and I revisited this one today, and think that it's no longer necessary in a world where automatic retries are universal and robust (because of #48183 and its many associated PRs). I'm going to close this PR and the associated issue (#44188), but we can reopen it if there's still a need for this kind of logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >enhancement Team:Data Management Meta label for data/management team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILM: _retry using wildcard should skip indices that are not managed by ILM
10 participants