-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILM _retry skips non-managed indices #51339
Conversation
This change makes `_retry` ILM endpoint to skip indices that are not managed by the ILM (i.e. don't have ILM metadata stored) instead of throwing exception. This allows user to call `*/_ilm/retry` and the request won't fail because of unmanaged indices (for example .monitoring-kibana-*) Closes elastic#44188
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this, it's a small thing that will be very nice. Could you add a small test for the functionality also?
I merged |
@dakrone and I revisited this one today, and think that it's no longer necessary in a world where automatic retries are universal and robust (because of #48183 and its many associated PRs). I'm going to close this PR and the associated issue (#44188), but we can reopen it if there's still a need for this kind of logic. |
This change makes
_retry
ILM endpoint to skip indices that are notmanaged by the ILM (i.e. don't have ILM metadata stored) instead of
throwing exception.
This allows user to call
*/_ilm/retry
and the request won't failbecause of unmanaged indices (for example .monitoring-kibana-*)
Closes #44188