Update track_total_hits to union type #51846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates track_total_hits parameter type to a union of boolean and number, to reflect the possible values that can be passed.
karmi
reviewed
Feb 4, 2020
karmi
reviewed
Feb 4, 2020
Co-Authored-By: Karel Minarik <karel.minarik@gmail.com>
russcam
commented
Feb 4, 2020
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
|
@russcam are you still wanting to progress this PR or should it be closed? |
|
Yes I am @colings86. If it LGTY, I'll merge and backport |
|
@elasticmachine update branch |
jimczi
approved these changes
May 25, 2020
russcam
added a commit
to russcam/elasticsearch
that referenced
this pull request
May 29, 2020
Relates: elastic#51846 This commit updates the async_search.submit.json REST API spec to make track_total_hits a union of boolean and long, to reflect the possible values that can be passed.
russcam
added a commit
that referenced
this pull request
Jun 2, 2020
Relates: #51846 This commit updates the async_search.submit.json REST API spec to make track_total_hits a union of boolean and long, to reflect the possible values that can be passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates track_total_hits parameter type to a union
of boolean and number, to reflect the possible values that can
be passed.