[Doc] migration guide joda #51986

pgomulka · 2020-02-06T09:59:29Z

closes #51614
closes #51236

elasticmachine · 2020-02-06T09:59:33Z

Pinging @elastic/es-docs (>docs)

pgomulka · 2020-02-25T13:53:39Z

@elasticmachine test this please

pgomulka · 2020-03-17T13:02:23Z

@elasticmachine test this please

docs/reference/migration/migrate_7_0/java_time.asciidoc

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

jrodewig · 2020-03-17T19:41:25Z

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

+Most of the custom date formats are compatible, but with some there is a change of meaning or missing. More on that below.
+A custom format is specified on a date field like this:
+[source,console]
+--------------------------------------------------
+PUT my_index
+{
+  "mappings": {
+    "properties": {
+      "date": {
+        "type":   "date",
+        "format": "YYYY/MM/dd HH:mm:ss||YYYY/MM/dd||epoch_millis"
+      }
+    }
+  }
+}
+--------------------------------------------------


I think we can remove this section entirely.

will remove

jrodewig · 2020-03-17T19:44:08Z

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

+}
+--------------------------------------------------
+
+To make sure if any of the date formats is deprecated run deprecation API or kibana upgrade assistant.


To see if your date format is impacted, use the <<migration-api-deprecation,deprecation info API>>
or the {kibana-ref}/upgrade-assistant.html[Kibana upgrade assistant]

jrodewig · 2020-03-17T19:44:36Z

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

+//todo fix this
+xx migration-api-deprecation xx
+xxinclude ::../apis/deprecation.asciidoc
+
+Sample output of deprecation api will be as follows:
+[source,text]
+--------------------------------------------------
+This index has date fields with deprecated formats: [[type: doc, field: param2, format: yyyy/MM/dd HH:mm:ss||yyyy/MM/dd||epoch_millis, suggestion: 'y' year should be replaced with 'u'. Use 'y' for year-of-era.]]. Prefix your date format with '8' to use the new specifier.
+--------------------------------------------------
+


I'm not sure if this is needed. I'd remove it.

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

jrodewig · 2020-03-17T19:53:41Z

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

+==== Incompatible formats
+If a pattern contains literals below, that means the pattern is incompatible and needs to be changed.
+
+===== Y - in 6.8 meaning Year of era. It should be replaced to y in 7.0 This is a big change because in 7.0 'Y' means week-based-year.


Rather than using headings =====, I'd create a definition list with each literal:

`Y` (Year of era):: + -- Replace with `y`. *Example:* `YYYY-MM-dd` should become `yyyy-MM-dd` In java time, `Y` is used for https://docs.oracle.com/javase/8/docs/api/java/time/temporal/WeekFields.html[week-based year]. Using `Y` in place of `y` could result in off-by-one errors in year calculation. --

good idea - fixed

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

…csearch into doc/migration_guide_joda

docs/reference/migration/migrate_7_0/java_time.asciidoc

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

jrodewig · 2020-03-20T14:27:58Z

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

+You can however update your pipelines or templates. Remember to look for templates you use with tools outside ES.
+If you specified a custom date format there, then you need to update it too.


I feel this is covered well later.

Suggested change

You can however update your pipelines or templates. Remember to look for templates you use with tools outside ES.

If you specified a custom date format there, then you need to update it too.

removed the part of external templates

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc

jrodewig

Overall LGTM.

I left some comments that should be addressed here:

The other comments are optional. Feel free to ignore them if you see fit.

…csearch into doc/migration_guide_joda

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

draft

9bbfc8b

pgomulka added the >docs General docs changes label Feb 6, 2020

pgomulka self-assigned this Feb 6, 2020

todo

e1752b1

pgomulka added 4 commits February 25, 2020 16:57

more docs

8fa601c

link

8770f30

docs fix

6bed675

fix build

44a7c7e

pgomulka added 2 commits March 17, 2020 15:30

formatting changes

7450e9c

cleanup and todos

eceb3b8

pgomulka changed the title ~~WIP [Doc] migration guide joda~~ [Doc] migration guide joda Mar 17, 2020

test fixes

fa9b661

jrodewig self-requested a review March 17, 2020 16:47

pgomulka added 2 commits March 17, 2020 17:52

test fix

d7f877b

Merge branch '7.x' into doc/migration_guide_joda

2cdf1ec

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 17, 2020

View reviewed changes

pgomulka and others added 9 commits March 20, 2020 13:17

Update docs/reference/migration/migrate_7_0/migrate_to_java_time.asci…

1efee67

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

Update docs/reference/migration/migrate_7_0/migrate_to_java_time.asci…

ba82ebb

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

Update docs/reference/migration/migrate_7_0/migrate_to_java_time.asci…

4abeabf

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

Update docs/reference/migration/migrate_7_0/migrate_to_java_time.asci…

1b389ea

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

Update docs/reference/migration/migrate_7_0/migrate_to_java_time.asci…

bad6adf

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

Update docs/reference/migration/migrate_7_0/migrate_to_java_time.asci…

70bc73d

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

Update docs/reference/migration/migrate_7_0/migrate_to_java_time.asci…

df97a0d

…idoc Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

Merge branch 'doc/migration_guide_joda' of github.com:pgomulka/elasti…

7443a3f

…csearch into doc/migration_guide_joda

rephrase update index mappings section

52690b9

jrodewig self-requested a review March 20, 2020 12:34

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

Apply suggestions from code review

5652714

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

jrodewig reviewed Mar 20, 2020

View reviewed changes

docs/reference/migration/migrate_7_0/migrate_to_java_time.asciidoc Outdated Show resolved Hide resolved

jrodewig approved these changes Mar 20, 2020

View reviewed changes

pgomulka and others added 3 commits March 20, 2020 15:50

remove the part of external pipelines form update index section

533bd1b

Merge branch 'doc/migration_guide_joda' of github.com:pgomulka/elasti…

aeaa1f2

…csearch into doc/migration_guide_joda

Apply suggestions from code review

ea1e0f2

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

pgomulka merged commit 412e163 into elastic:7.x Mar 23, 2020

This was referenced Apr 24, 2020

[Java.time] Document or fix timeezone migration #51614

Closed

[DOCS] Would like to include some verbiage on java time vs joda time #51236

Closed

ChrisHegarty unassigned pgomulka Oct 29, 2024

		You can however update your pipelines or templates. Remember to look for templates you use with tools outside ES.
		If you specified a custom date format there, then you need to update it too.

[Doc] migration guide joda #51986

[Doc] migration guide joda #51986

Uh oh!

Conversation

pgomulka commented Feb 6, 2020

Uh oh!

elasticmachine commented Feb 6, 2020

Uh oh!

pgomulka commented Feb 25, 2020

Uh oh!

pgomulka commented Mar 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrodewig Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

pgomulka Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

jrodewig Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

jrodewig Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jrodewig Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pgomulka Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrodewig Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

pgomulka Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrodewig left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jrodewig Mar 17, 2020 •

edited

Loading