Add autoscaling feature flag in release REST tests #52096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REST tests for autoscaling either need to be skipped in a non-snapshot build, or alternatively, the feature flag registered so that autoscaling can be enabled. We prefer the latter approach, as it allows us to also test autoscaling in non-snapshot builds incrementally, instead of at the end of development as autoscaling prepares for release. This commit registers the autoscaling feature flag in REST tests for non-snapshot builds.
|
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
|
Here is a build scan showing the issue. |
9 tasks
jasontedor
added a commit
that referenced
this pull request
Feb 9, 2020
The REST tests for autoscaling either need to be skipped in a non-snapshot build, or alternatively, the feature flag registered so that autoscaling can be enabled. We prefer the latter approach, as it allows us to also test autoscaling in non-snapshot builds incrementally, instead of at the end of development as autoscaling prepares for release. This commit registers the autoscaling feature flag in REST tests for non-snapshot builds.
jasontedor
deleted the
register-autoscaling-feature-flag-release-rest-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST tests for autoscaling either need to be skipped in a non-snapshot build, or alternatively, the feature flag registered so that autoscaling can be enabled. We prefer the latter approach, as it allows us to also test autoscaling in non-snapshot builds incrementally, instead of at the end of development as autoscaling prepares for release. This commit registers the autoscaling feature flag in REST tests for non-snapshot builds.
Relates #52088