Fix mixed threadlocal and supplied random use #52459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#52450. `setRandomIndexSettings(...)` in `ESIntegTestCase` was using both a thread-local and a supplied source of randomness. Fix this method to only use the supplied source.
pugnascotia
added
>bug
>test
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
pugnascotia
added a commit
that referenced
this pull request
Feb 18, 2020
Closes #52450. `setRandomIndexSettings(...)` in `ESIntegTestCase` was using both a thread-local and a supplied source of randomness. Fix this method to only use the supplied source.
Contributor
Author
|
Backported in 4fb3993 |
sbourke
pushed a commit
to sbourke/elasticsearch
that referenced
this pull request
Feb 19, 2020
Closes elastic#52450. `setRandomIndexSettings(...)` in `ESIntegTestCase` was using both a thread-local and a supplied source of randomness. Fix this method to only use the supplied source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52450.
setRandomIndexSettings(...)inESIntegTestCasewasusing both a thread-local and a supplied source of randomness. Fix this
method to only use the supplied source.