Skip to content

Update Docker on linux exclusion list #52736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Feb 24, 2020

This pull request updates our exclusion logic for slipping Docker-based build tasks on certain Linux distributions. We have been inadvertently running Docker tasks on SLES distributions because /etc/os-release reports and ID of SLES instead of sles and VERSION of 12.4 instead of 12. This PR fixes the former issue by simply forcing all reported values to lower-case so we don't have to worry about any discrepancies there, as well as adding the explicit service-pack version to our exclusion list.

I've also added SLES 15 to the naughty list due to the continues occurrences of this issue on that OS.

Signed-off-by: Mark Vieira <portugee@gmail.com>
@mark-vieira mark-vieira added the :Delivery/Build Build or test infrastructure label Feb 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-vieira mark-vieira merged commit 5cfbf4d into elastic:master Feb 25, 2020
mark-vieira added a commit that referenced this pull request Feb 25, 2020
mark-vieira added a commit that referenced this pull request Feb 25, 2020
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants