Deprecate BoolQueryBuilder's mustNot field #53125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Contributor
Author
|
@elasticmachine update branch |
jtibshirani
approved these changes
Mar 6, 2020
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
This looks good to me, great to clean this up!
romseygeek
added a commit
that referenced
this pull request
Mar 6, 2020
The bool query builder in elasticsearch accepts both must_not and mustNot fields. Given that leniency is abhorrent and must be eschewed, we should deprecate the latter as it doesn't fit with the style of parameters elsewhere in the DSL.
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
boolquery builder in elasticsearch accepts bothmust_notandmustNotfields. Given that leniency is abhorrent and must be eschewed, we should deprecate
the latter as it doesn't fit with the style of parameters elsewhere in the DSL.