Skip to content

Conversation

@polyfractal
Copy link
Contributor

These were added in #53132, but I forgot to merge them to master first 😱

Adds some unit tests for scripting, unmapped fields and "supported types"

@polyfractal polyfractal added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations labels Mar 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

Copy link
Contributor

@andyb-elastic andyb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only thing I'd suggest (maybe in another pr since these are already on the feature branch) is testing the missing parameter with a field that is mapped, I think all the ones here use an unmapped field

@polyfractal
Copy link
Contributor Author

Ooh good catch, didn't notice that. I'll go ahead and add to this PR

@polyfractal
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I thought these are not needed for this aggregation since we are testing these code paths already in a few others. But I guess I could have messed up handling here. So, good catch!

@polyfractal
Copy link
Contributor Author

Yah, it's mostly that we're just dotting i's and crossing t's to make sure the VS refactor, when it merges, doesn't change anything that we didn't expect. So trying to add test parity across all the aggs ahead of time to prevent any surprises :)

@polyfractal polyfractal merged commit e98b9c0 into elastic:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants