Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/_cat/shards support path stats #53461

Merged
merged 9 commits into from
Mar 23, 2020
Merged

/_cat/shards support path stats #53461

merged 9 commits into from
Mar 23, 2020

Conversation

weizijun
Copy link
Contributor

@weizijun weizijun commented Mar 12, 2020 •
edited
Loading

/_cat/shards cant support path stats. so where path.data uses multiple paths, _cat/shards can be used to view the path of each shard

@weizijun weizijun changed the title _cat/shards support path stats /_cat/shards support path stats Mar 12, 2020
@cbuescher cbuescher added the :Data Management/CAT APIs Text APIs behind /_cat label Mar 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

@jakelandis jakelandis requested a review from probakowski March 12, 2020 14:26
probakowski
probakowski suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @weizijun! I've left couple of style suggestions, other than that it's good to go, I'll run tests and merge it as soon as you can update them

server/src/test/java/org/elasticsearch/rest/action/cat/RestShardsActionTests.java Outdated Show resolved Hide resolved
server/src/test/java/org/elasticsearch/rest/action/cat/RestShardsActionTests.java Outdated Show resolved Hide resolved
server/src/test/java/org/elasticsearch/rest/action/cat/RestShardsActionTests.java Outdated Show resolved Hide resolved
server/src/test/java/org/elasticsearch/rest/action/cat/RestShardsActionTests.java Outdated Show resolved Hide resolved
@weizijun
Copy link
Contributor Author

Thanks for working on this @weizijun! I've left couple of style suggestions, other than that it's good to go, I'll run tests and merge it as soon as you can update them

@probakowski Thank you very much for review, I have fixed these problem.

probakowski
probakowski approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@probakowski probakowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@probakowski
Copy link
Contributor

@elasticmachine ok to test

@weizijun
Copy link
Contributor Author

hi, @probakowski , I fix the rest-api-spec cat.shards error.

@probakowski
Copy link
Contributor

@elasticmachine update branch

@probakowski
Copy link
Contributor

@weizijun there are still tests failing and it seems strongly connected (MixedClusterClientYamlTestSuiteIT.test {p0=cat.shards/10_basic/Help}), can you please fix it?

@weizijun
Copy link
Contributor Author

@weizijun there are still tests failing and it seems strongly connected (MixedClusterClientYamlTestSuiteIT.test {p0=cat.shards/10_basic/Help}), can you please fix it?

ok, I'am trying to fix the mixedClusterTest.

@weizijun
Copy link
Contributor Author

HI, @probakowski !, I fixed the bwc error. But some other case run error. Can you help to update branch again! Thank you very much!

@weizijun
Copy link
Contributor Author

@elasticmachine update branch

@weizijun
Copy link
Contributor Author

@elasticmachine update branch

@weizijun
Copy link
Contributor Author

@elasticmachine update branch

@weizijun
Copy link
Contributor Author

hi, @probakowski @jakelandis , can you help to merge this pr? thanks!

@probakowski probakowski merged commit face375 into elastic:master Mar 23, 2020
@probakowski
Copy link
Contributor

Thanks @weizijun for working on this and fixing all issues, I've merged PR to master and will backport it soon to 7.x

@weizijun
Copy link
Contributor Author

Thanks @weizijun for working on this and fixing all issues, I've merged PR to master and will backport it soon to 7.x

Thank you @probakowski ！

probakowski pushed a commit to probakowski/elasticsearch that referenced this pull request Mar 24, 2020
@weizijun @elasticmachine @probakowski
/_cat/shards support path stats (elastic#53461)
d92b2e0 
* _cat/shards support path stats

* fix some style case

* fix some style case

* fix rest-api-spec cat.shards error

* fix rest-api-spec cat.shards bwc error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
probakowski added a commit that referenced this pull request Mar 24, 2020
@probakowski @weizijun @elasticmachine
/_cat/shards support path stats (#53461) (#54119)
5594d57 
* _cat/shards support path stats

* fix some style case

* fix some style case

* fix rest-api-spec cat.shards error

* fix rest-api-spec cat.shards bwc error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: weizijun <weizijun1989@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
@codebrain codebrain mentioned this pull request Apr 14, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probakowski probakowski probakowski approved these changes

Assignees
No one assigned
Labels
:Data Management/CAT APIs Text APIs behind /_cat >enhancement v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weizijun @elasticmachine @probakowski @jakelandis @cbuescher