Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for fractional byte size values #53927

Closed

Conversation

jasontedor
Copy link
Member

These have been deprecated since Elasticsearch 6.2.0. This commit finishes them off by removing support for parsing them.

Relates #27702

These have been deprecated since Elasticsearch 6.2.0. This commit
finishes them off by removing support for parsing them.
@jasontedor jasontedor added >breaking :Core/Infra/Core Core issues without another label v8.0.0 labels Mar 21, 2020
@jasontedor jasontedor requested a review from colings86 March 21, 2020 23:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@cjcenizal
Copy link
Contributor

@jasontedor The underlying issue (#27568) has this to say about handling the change in 7.0:

Auto-upgrade cluster and index settings from LegacyByteSizeValue to ByteSizeValue (the new one) and remove LegacyByteSizeValue. Fractional bytes values in elasticsearch.yml will need to be manually changed by the user when upgrading to 7.0 or can be changed before upgrading.

I might be confused, but the issue also notes that this change affects not only settings but API parameters that are byte values as well. Do we need to consider the upgrade path for any documents created with fractional byte size values? For example, an ILM policy with fractional byte size values? Or is this what was meant by "index settings"?

@jasontedor
Copy link
Member Author

I might be confused, but the issue also notes that this change affects not only settings but API parameters that are byte values as well. Do we need to consider the upgrade path for any documents created with fractional byte size values? For example, an ILM policy with fractional byte size values? Or is this what was meant by "index settings"?

Documents are not an issue since we don't have any mappers that parse byte size values today. The upgrade issue only pertains to:

  • cluster settings
  • index settings
  • cluster state metadata that uses byte size values (e.g., an ILM policy)

The work to automatically upgrade these was suppose to have been done as part of the 7.0.0 work, but it appears it was not so we are left with this legacy for another major release. To complete this work, we have to do the following:

  • add code to upgrade any byte size setting in the cluster state; we have infrastructure for this
  • add code to upgrade any byte size setting in an index; we have infrastructure for this
  • add code to all cluster state metadata to be upgraded; we don't have infrastructure for this

Given that we are not ready (as I thought since #27568 is closed), I will close this pull request for now.

@jasontedor jasontedor closed this Mar 22, 2020
@jasontedor jasontedor deleted the remove-fractional-byte-size-values branch March 22, 2020 13:40
masseyke added a commit that referenced this pull request Sep 7, 2021
#77074)

In 6.2.0 we deprecated support for fractional byte value settings. Support was originally going to be
removed altogether in 8.0.0 (see #53927) but that PR was not merged. This commit adds a warning
deprecation info check if any fractional byte values settings are found.
Relates #42404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Core Core issues without another label v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants