-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for fractional byte size values #53927
Remove support for fractional byte size values #53927
Conversation
These have been deprecated since Elasticsearch 6.2.0. This commit finishes them off by removing support for parsing them.
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
@jasontedor The underlying issue (#27568) has this to say about handling the change in 7.0:
I might be confused, but the issue also notes that this change affects not only settings but API parameters that are byte values as well. Do we need to consider the upgrade path for any documents created with fractional byte size values? For example, an ILM policy with fractional byte size values? Or is this what was meant by "index settings"? |
Documents are not an issue since we don't have any mappers that parse byte size values today. The upgrade issue only pertains to:
The work to automatically upgrade these was suppose to have been done as part of the 7.0.0 work, but it appears it was not so we are left with this legacy for another major release. To complete this work, we have to do the following:
Given that we are not ready (as I thought since #27568 is closed), I will close this pull request for now. |
These have been deprecated since Elasticsearch 6.2.0. This commit finishes them off by removing support for parsing them.
Relates #27702