-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Async search: clarify behaviour when submit returns final results #55934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left minor comments
@@ -98,7 +98,11 @@ some shards returned their results, or when the node that is coordinating the | |||
|
|||
It is possible to block and wait until the search is completed up to a certain | |||
timeout by providing the `wait_for_completion_timeout` parameter, which | |||
defaults to `1` second. | |||
defaults to `1` second. When the async search completes within such timeout, | |||
the response won't include the ID as the results are not stored in the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/the ID/the id
/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is how @jrodewig prefers us to mention the id, I will defer to him :)
defaults to `1` second. When the async search completes within such timeout, | ||
the response won't include the ID as the results are not stored in the cluster. | ||
The `keep_on_completion` parameter, which defaults to `false`, can be set to | ||
`true` to request that when the async search completes within the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/when the async search completes/when the search completes/ ? It's a parameter for a blocking API so async is maybe misleading.
Closes #55636