Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Async search: clarify behaviour when submit returns final results #55934

Merged
merged 4 commits into from
May 6, 2020

Conversation

javanna
Copy link
Member

@javanna javanna commented Apr 29, 2020

Closes #55636

@javanna javanna added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.7.0 v7.8.0 labels Apr 29, 2020
@javanna javanna requested a review from jimczi April 29, 2020 13:35
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor comments

@@ -98,7 +98,11 @@ some shards returned their results, or when the node that is coordinating the

It is possible to block and wait until the search is completed up to a certain
timeout by providing the `wait_for_completion_timeout` parameter, which
defaults to `1` second.
defaults to `1` second. When the async search completes within such timeout,
the response won't include the ID as the results are not stored in the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/the ID/the id/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is how @jrodewig prefers us to mention the id, I will defer to him :)

defaults to `1` second. When the async search completes within such timeout,
the response won't include the ID as the results are not stored in the cluster.
The `keep_on_completion` parameter, which defaults to `false`, can be set to
`true` to request that when the async search completes within the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/when the async search completes/when the search completes/ ? It's a parameter for a blocking API so async is maybe misleading.

@rjernst rjernst added Team:Docs Meta label for docs team Team:Search Meta label for search team labels May 4, 2020
@pugnascotia pugnascotia added v7.8.1 and removed v7.8.0 labels May 6, 2020
@javanna javanna merged commit 6a69ab4 into elastic:master May 6, 2020
@javanna javanna added the v7.9.0 label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v7.7.0 v7.8.1 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Async search response ID clarification
5 participants