Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [ML] Allow a certain number of ill-formatted rows when delimited format is specified (#55735) #55944

Merged
merged 1 commit into from
Apr 29, 2020
Merged

[7.x] [ML] Allow a certain number of ill-formatted rows when delimited format is specified (#55735) #55944

merged 1 commit into from
Apr 29, 2020

Commits on Apr 29, 2020

  1. [ML] Allow a certain number of ill-formatted rows when delimited form… 

    …at is specified (elastic#55735)

While it is good to not be lenient when attempting to guess the file format, it is frustrating to users when they KNOW it is CSV but there are a few ill-formatted rows in the file (via some entry error, etc.).

This commit allows for up to 10% of sample rows to be considered "bad". These rows are effectively ignored while guessing the format.

This percentage of "allows bad rows" is only applied when the user has specified delimited formatting options. As the structure finder needs some guidance on what a "bad row" actually means.

related to elastic#38890
    @benwtrent
    benwtrent committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    0b321cc View commit details
    Browse the repository at this point in the history