[DOCS] Add manual redirects for topics that are 404-ing in current. #55989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-docs (>docs) |
jrodewig
reviewed
Apr 30, 2020
| @@ -493,3 +493,71 @@ See <<ilm-actions>>. | |||
| === {ilm-init} policy definition | |||
|
|
|||
| See <<ilm-index-lifecycle>>. | |||
|
|
|||
| [role="exclude",id="mapping-nested-type"] | |||
| === Installing {es} | |||
There was a problem hiding this comment.
Wrong heading.
Suggested change
| === Installing {es} | |
| === Nested field datatype |
jrodewig
reviewed
Apr 30, 2020
|
|
||
|
|
||
| [role="exclude",id="mapping-timestamp-field"] | ||
| === |
There was a problem hiding this comment.
Missing heading.
Suggested change
| === | |
| === Mapping timestamp fields |
jrodewig
suggested changes
Apr 30, 2020
There was a problem hiding this comment.
Left some suggestions for stuff to fix.
I'm also not sure if adding this to redirects.asciidoc is the best move, particularly on the master branch.
I've opened a ticket to add server-side redirects for most of these. I think that should be sufficient.
If you decide you'd like to have the redirects in this file too, I'd put them no later than 7.x. We should use master/new major as an opportunity to wipe the slate clean (if we have server redirects set up).
|
Closing in favor of the server-side redirects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still getting a fair number of 404s for external links to current for long-deprecated topics, particularly around the filter changes. Adding them to the redirects file.
Also looking into how we can better manage redirects and avoid 404s, particularly when we restructure content. (elastic/docs#1820)