Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Docs changes for overridden delimiter in find_file_structure #56288

Merged
merged 4 commits into from
May 14, 2020

Conversation

droberts195
Copy link
Contributor

Docs for #55735

@droberts195 droberts195 added >docs General docs changes :ml Machine learning v8.0.0 v7.8.0 v7.9.0 labels May 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 6, 2020
@lcawl
Copy link
Contributor

lcawl commented May 6, 2020

I added a commit that puts the two sentences about default behaviour together in both descriptions. If this change has affected the technical accuracy of this content, just let me know.

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM

…sciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@droberts195 droberts195 merged commit cbb8b17 into elastic:master May 14, 2020
@droberts195 droberts195 deleted the docs_for_overridden_delimiter branch May 14, 2020 08:24
droberts195 added a commit that referenced this pull request May 14, 2020
…56288)

Docs for #55735

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
droberts195 added a commit that referenced this pull request May 14, 2020
…56288)

Docs for #55735

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning Team:Docs Meta label for docs team v7.8.0 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants