Do not daemonize when testing error output in packaging tests #56971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The packaging tests start elasticsearch in various ways. All of these currently expect it is started asynchronously, yet some tests expect it will fail to start and want to check the error output. This commit adds a daemonize flag to the utility methods to start elasticsearch for such cases, so that when the start method returns, all the error output should already be available since the process will have exited. relates elastic#51716
rjernst
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
pugnascotia
approved these changes
May 20, 2020
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 20, 2020
…c#56971) The packaging tests start elasticsearch in various ways. All of these currently expect it is started asynchronously, yet some tests expect it will fail to start and want to check the error output. This commit adds a daemonize flag to the utility methods to start elasticsearch for such cases, so that when the start method returns, all the error output should already be available since the process will have exited. relates elastic#51716
rjernst
added a commit
that referenced
this pull request
May 20, 2020
#56997) The packaging tests start elasticsearch in various ways. All of these currently expect it is started asynchronously, yet some tests expect it will fail to start and want to check the error output. This commit adds a daemonize flag to the utility methods to start elasticsearch for such cases, so that when the start method returns, all the error output should already be available since the process will have exited. relates #51716
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packaging tests start elasticsearch in various ways. All of these
currently expect it is started asynchronously, yet some tests expect it
will fail to start and want to check the error output. This commit adds
a daemonize flag to the utility methods to start elasticsearch for such
cases, so that when the start method returns, all the error output
should already be available since the process will have exited.
relates #51716