Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference on returning fields during a search. #57500

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

jtibshirani
Copy link
Contributor

This PR adds a section to the new 'run a search' reference that explains
the options for returning fields. Previously each option was only listed as a
separate request parameter and it was hard to know what was available.

@jtibshirani jtibshirani added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories labels Jun 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 2, 2020
This PR adds a section to the new 'run a search' reference that explains
the options for returning fields. Previously each option was only listed as a
separate request parameter and it was hard to know what was available.
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I left some suggestions for non-blocking nits. Feel free to ignore them as wanted. This is fine as-is.

Thanks for this addition @jtibshirani.

docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-fields.asciidoc Outdated Show resolved Hide resolved
@jtibshirani
Copy link
Contributor Author

Thanks @jrodewig for reviewing, I really value these types of lower-level writing suggestions.

@jtibshirani jtibshirani merged commit de9b91f into elastic:master Jun 3, 2020
@jtibshirani jtibshirani deleted the search-fields branch June 3, 2020 16:33
jtibshirani added a commit that referenced this pull request Jun 3, 2020
This PR adds a section to the new 'run a search' reference that explains
the options for returning fields. Previously each option was only listed as a
separate request parameter and it was hard to know what was available.
jtibshirani added a commit that referenced this pull request Jun 3, 2020
This PR adds a section to the new 'run a search' reference that explains
the options for returning fields. Previously each option was only listed as a
separate request parameter and it was hard to know what was available.
jtibshirani added a commit that referenced this pull request Jun 3, 2020
This PR adds a section to the new 'run a search' reference that explains
the options for returning fields. Previously each option was only listed as a
separate request parameter and it was hard to know what was available.
@jtibshirani jtibshirani removed the v6.8.0 label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v7.7.0 v7.8.0 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants