HLRC for delete expired data by job Id #57722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
benwtrent
reviewed
Jun 5, 2020
| @@ -51,6 +52,14 @@ private DeleteExpiredDataAction() { | |||
| PARSER.declareString(Request::setJobId, Job.ID); | |||
| } | |||
|
|
|||
| public static Request parseRequest(String jobId, XContentParser parser) { | |||
There was a problem hiding this comment.
Is this supposed to be used anywhere?
There was a problem hiding this comment.
Yes it is. Good spot thanks
benwtrent
reviewed
Jun 5, 2020
...lugin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/DeleteExpiredDataAction.java
Show resolved
Hide resolved
davidkyle
force-pushed
the
expire-job-id-hlrc
branch
from
15a756e to
f90513c
Compare
davidkyle
force-pushed
the
expire-job-id-hlrc
branch
from
f90513c to
d02ac2f
Compare
benwtrent
approved these changes
Jun 10, 2020
davidkyle
force-pushed
the
expire-job-id-hlrc
branch
from
591b81a to
b7d3501
Compare
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Jun 12, 2020
High level rest client changes for elastic#57337
davidkyle
added a commit
that referenced
this pull request
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level rest client changes for #57337
Non issue as covered by #57337