Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds scope to monitoring #57852

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 8, 2020

@lcawl lcawl requested a review from ycombinator June 9, 2020 15:57
@lcawl lcawl marked this pull request as ready for review June 9, 2020 15:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Monitoring)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 9, 2020
@ycombinator
Copy link
Contributor

Thanks for the PR. I think we should keep the original step 3 as is, the one in which we ask users to enable the Elasticsearch X-Pack module.

Also, we can just remove step 4 in master and 7.x, as enabling the Elasticsearch X-Pack module now auto-enables the appropriate metricsets (starting from 7.8.0; see elastic/beats#17609).

@lcawl
Copy link
Contributor Author

lcawl commented Jun 9, 2020

I think we should keep the original step 3 as is, the one in which we ask users to enable the Elasticsearch X-Pack module.

Thanks for the feedback! I've reverted to the use of the Elasticsearch X-Pack module but have added a link for the alternative method.

Also, we can just remove step 4

I've left it in to show the placement of the scope attribute, but have removed the metricsets to align with what I see in my 7.8 tests. I've also added callouts to the example so it's a bit clearer.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay!

@lcawl lcawl added the v7.10.0 label Aug 4, 2020
@lcawl lcawl merged commit 5e28513 into elastic:master Aug 4, 2020
@lcawl lcawl deleted the mb-es-cluster-mode branch August 4, 2020 16:01
lcawl added a commit to lcawl/elasticsearch that referenced this pull request Aug 4, 2020
lcawl added a commit to lcawl/elasticsearch that referenced this pull request Aug 4, 2020
lcawl added a commit that referenced this pull request Aug 4, 2020
lcawl added a commit that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Monitoring >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.9.0 v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ES monitoring with Metricbeat doc with new scope setting
4 participants