-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds scope to monitoring #57852
Conversation
Pinging @elastic/es-core-features (:Core/Features/Monitoring) |
Pinging @elastic/es-docs (>docs) |
Thanks for the PR. I think we should keep the original step 3 as is, the one in which we ask users to enable the Elasticsearch X-Pack module. Also, we can just remove step 4 in |
Thanks for the feedback! I've reverted to the use of the Elasticsearch X-Pack module but have added a link for the alternative method.
I've left it in to show the placement of the scope attribute, but have removed the metricsets to align with what I see in my 7.8 tests. I've also added callouts to the example so it's a bit clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the delay!
Fixes #57217
Related to elastic/beats#18547
This PR also switches the instructions in https://www.elastic.co/guide/en/elasticsearch/reference/master/configuring-metricbeat.html so that it matches https://www.elastic.co/guide/en/beats/metricbeat/master/metricbeat-module-elasticsearch.html
and recommends the Elasticsearch module instead of the Elasticsearch X-Pack module.
Preview
https://elasticsearch_57852.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/configuring-metricbeat.html