Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix info message for starting RunTask in debug mode #57974

Merged

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jun 11, 2020

The lifecycle log messages was misleading and outdated causing some confusion for community members. This fixes the emitted message when starting with --debug-jvm flag.

Fixes #57860

@breskeby breskeby self-assigned this Jun 11, 2020
@breskeby breskeby added :Delivery/Build Build or test infrastructure Team:Core/Infra Meta label for core/infra team v7.7.2 v7.8.1 v7.9.0 v8.0.0 labels Jun 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@breskeby breskeby requested a review from alpar-t June 11, 2020 09:15
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breskeby breskeby merged commit 7a4093d into elastic:master Jun 11, 2020
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jun 11, 2020
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jun 11, 2020
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jun 11, 2020
breskeby added a commit that referenced this pull request Jun 12, 2020
Fixes #57860

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
@breskeby breskeby deleted the provide-warning-about-expected-debug-server branch December 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.7.2 v7.8.1 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running plugin with "gradle run --debug-jvm" seems to be broken after version 7.4.x
5 participants