Skip to content

Update hh to HH in date processor example #58089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Update hh to HH in date processor example #58089

merged 2 commits into from
Jun 15, 2020

Conversation

Leaf-Lin
Copy link
Contributor

hh should be HH according to https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html#strict-date-time

It would be good to have this date format link on this page so that people find it easily.

hh should be HH according to https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html#strict-date-time

It would be good to have the date format link on this page so that people find it easily.
@Leaf-Lin Leaf-Lin requested a review from jasontedor June 15, 2020 05:06
@Leaf-Lin Leaf-Lin marked this pull request as draft June 15, 2020 05:41
Adding https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html#strict-date-time for `java time pattern`, although it would be good if someone can double check that's how link works with asciidoc..
@Leaf-Lin Leaf-Lin marked this pull request as ready for review June 15, 2020 05:50
@jasontedor jasontedor requested review from jakelandis and removed request for jasontedor June 15, 2020 19:41
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this. I will handle the forward ports.

@jakelandis jakelandis merged commit 7cf329b into 7.7 Jun 15, 2020
@jakelandis jakelandis deleted the Leaf-Lin-patch-1 branch June 15, 2020 21:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 15, 2020
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this pull request Jun 15, 2020
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this pull request Jun 15, 2020
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this pull request Jun 15, 2020
jakelandis added a commit that referenced this pull request Jun 15, 2020
Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
jakelandis added a commit that referenced this pull request Jun 15, 2020
Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
jakelandis added a commit that referenced this pull request Jun 15, 2020
Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v7.7.0 v7.8.0 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants