Handle failures with no explicit cause in async search #58319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an AOOBE in the handling of fatal failures in _async_search. If the underlying cause is not found, this change uses the root failure. Closes elastic#58311
jimczi
added
>bug
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
javanna
approved these changes
Jun 18, 2020
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM, I am fine with the integ test, but I was wondering if it was not possible to introduce a unit test for this. IT tests take time and have a lot of moving parts.
jimczi
added a commit
that referenced
this pull request
Jun 18, 2020
This commit fixes an AOOBE in the handling of fatal failures in _async_search. If the underlying cause is not found, this change uses the root failure. Closes #58311
jimczi
added a commit
that referenced
this pull request
Jun 18, 2020
This commit fixes an AOOBE in the handling of fatal failures in _async_search. If the underlying cause is not found, this change uses the root failure. Closes #58311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an AOOBE in the handling of fatal failures in _async_search.
If the underlying cause is not found, this change uses the root failure instead of throwing an uncaught exception.
Closes #58311
Relates #57925