EQL: code cleanup and further tests #58458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefan
added
>enhancement
>test
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
elasticmachine
added
the
Team:QL (Deprecated)
matriv
approved these changes
Jun 24, 2020
| @@ -85,6 +85,10 @@ public ConcatFunctionProcessor asProcessor() { | |||
| return new ConcatFunctionProcessor(processors); | |||
| } | |||
|
|
|||
| public List<Pipe> values() { | |||
There was a problem hiding this comment.
Is public necessary? can it be package private?
There was a problem hiding this comment.
Yes, can be package private.
| @@ -559,7 +559,7 @@ private Object makeMap(Class<? extends Node<?>> toBuildClass, ParameterizedType | |||
|
|
|||
| private int randomSizeForCollection(Class<? extends Node<?>> toBuildClass) { | |||
| int minCollectionLength = 0; | |||
| int maxCollectionLength = 10; | |||
| int maxCollectionLength = 3; | |||
There was a problem hiding this comment.
Good catch. That's a leftover from an attempt to add EqlNodeSubclassTests to EQL. Will revert it.
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Jun 24, 2020
Add FunctionPipe tests to all functions. Cleanup functions code. (cherry picked from commit 0f83d57)
astefan
added a commit
that referenced
this pull request
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringandsubstringfunctionsinputnamed parameter to avoid confusion with the already existentsource,srcin all functions related classesA wide NodeSubclass test class to be added later with #53862.
Addresses #54568.