Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Refresh transform screenshots with histograms #59264

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 9, 2020

@lcawl lcawl added >docs General docs changes v8.0.0 :ml/Transform Transform v7.9.0 labels Jul 9, 2020
@lcawl lcawl marked this pull request as ready for review July 9, 2020 14:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 9, 2020
@lcawl lcawl requested a review from walterra July 9, 2020 14:58
@@ -42,7 +43,7 @@ Go to *Management* > *Elasticsearch* > *Transforms* in {kib} and use the
wizard to create a {transform}:

[role="screenshot"]
image::images/ecommerce-pivot1.jpg["Creating a simple {transform} in {kib}"]
image::images/ecommerce-pivot1.png["Creating a simple {transform} in {kib}"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would retake this screenshot to use a selection of columns which show off the histogram charts better - specifically try and include some numeric fields. For example:

image

This selection also includes the numeric taxless_total_price and total_quantity which you use in the example transform. The distribution chart of the country_iso_codes also looks nice!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peteharverson I've updated the screenshots with the columns you suggested front and centre

@lcawl
Copy link
Contributor Author

lcawl commented Jul 22, 2020

@elasticmachine run elasticsearch-ci/docs

Copy link

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New screenshot LGTM!

@lcawl lcawl added the v7.10.0 label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml/Transform Transform Team:Docs Meta label for docs team v7.9.0 v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants