-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fix data stream docs #59818
[DOCS] Fix data stream docs #59818
Conversation
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
Pinging @elastic/es-docs (>docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read the text in detail, but I really like the new structure and layout. It nicely addresses the aspects I found unclear earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments/suggestions. It occurs to me that we'll ultimately want to show the UI here, as well. Future fun. :-)
I think that consolidating the overview information helps. I struggled with the same problem with ILM and ended up duplicating some info because the Overview just felt incomplete without it.
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!
As a separate aside, how should we document the now newly built-in templates for logs-*-*
and metrics-*-*
as it relates to the new indexing strategy? Do we have docs for that already?
AFAIK we don't have docs for them, but we should. I think most of that content belongs with the index template docs. However, we probably want to update these docs to at least mention the priority in case of a naming collision. In any case, that's probably better suited for a separate PR. I'll coordinate with @debadair to see who will handle that work. Relates to #57629. |
Updates the data streams documentation based on feedback.
Changes:
Any additional feedback is welcome.
Previews