Introduce reserved_ml_apm_user kibana privilege #59854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
:Security/Authorization
|
Pinging @elastic/es-security (:Security/Authorization) |
sorenlouv
reviewed
Jul 20, 2020
| }, null, MetadataUtils.DEFAULT_RESERVED_METADATA)) | ||
| }, new RoleDescriptor.ApplicationResourcePrivileges[] { | ||
| RoleDescriptor.ApplicationResourcePrivileges.builder() | ||
| .application("kibana-*").resources("*").privileges("reserved_ml_apm_user").build() |
There was a problem hiding this comment.
Clarifying question since I'm not familiar with "reserved" privileges: I couldn't find reserved_ml_apm_user in elastic/kibana#72266 but I did find ml_apm_user. Is reserved_ an implied prefix somehow?
There was a problem hiding this comment.
Good question. Yes, the reserved_ prefix is generated by Kibana's security plugin when it "serializes" our privilege model into Elasticsearch's Application Privilege model:
legrego
added a commit
to legrego/elasticsearch
that referenced
this pull request
Jul 22, 2020
legrego
added a commit
that referenced
this pull request
Jul 22, 2020
legrego
added a commit
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Kibana "reserved" Kibana application privilege to the
apm_userrole, in order to grant access to a subset of ML functionality within Kibana.Previously, the
apm_userrole was authorized to retrieve ML jobs by virtue of its privileges against the.ml-anomalies*set of indices. This access is no longer sufficient, now that the ML feature is taking advantage of the Kibana privilege model.In order to maintain BWC for existing users of the
apm_userrole, it's necessary to create a reserved privilege which mimics the previous access that this role used to have. Eventually, the Kibana privilege model will be updated to support access to ML jobs in a more holistic manner, but that is a longer term initiative.Corresponding Kibana PR: elastic/kibana#72266