Pass a SearchLookup supplier through to fielddataBuilder #60224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime fields depend on SearchLookup to be able to look up other fields and manipulate them. With this change we add a SearchLookup argument to the existing MappedFieldType#fielddataBuilder method. Additionally the use of runtime fields in index sorting is disallowed. Relates to elastic#59332
javanna
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
30 tasks
nik9000
approved these changes
Jul 27, 2020
| @@ -26,26 +24,37 @@ | |||
|
|
|||
| protected abstract String runtimeType(); | |||
|
|
|||
| @SuppressWarnings("unused") | |||
There was a problem hiding this comment.
Is this because intellij doesn't like these methods because they are only called by the test framework?
There was a problem hiding this comment.
yes, not that important, I got annoyed with all the warnings hence I addressed them. I can also revert if there are cons
There was a problem hiding this comment.
Nah. No need. I didn't realize IntelliJ would warn about it.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Aug 20, 2020
Runtime fields look up other fields through `SearchLookup`. With this change we add a `Supplier<SearchLookup>` argument to the existing `MappedFieldType#fielddataBuilder` method so that fielddata implementations can have `SearchLookup` available when needed. Note that this commit does not introduce any production implementation of runtime fields, but rather the plumbing needed to then merge the feature branch where runtime fields have been developed. Additionally the use of runtime fields in index sorting is disallowed. Relates to elastic#59332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime fields depend on SearchLookup to be able to look up other fields and manipulate them. With this change we add a SearchLookup argument to the existing MappedFieldType#fielddataBuilder method. Additionally the use of runtime fields in index sorting is disallowed.
This is essentially #58527 but refined and made to the runtime fields feature branch. We have introduced a temporary way to make SearchLookup available as part of #58939 to minimize merge conflicts in a feature branch, but it is now time to make this change permanent.
Relates to #59332