Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPV6 Scope ID Test #60360

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

original-brownbear
Copy link
Member

Use real scope id from first available interface instead of lo which might
not exist on non-Linux platforms.

Closes #60332

Use real scope id from first available interface instead of `lo` which might
not exist on non-Linux platforms.

Closes elastic#60332
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Network Http and internode communication implementations v8.0.0 v7.10.0 labels Jul 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Network)

@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team (obsolete) label Jul 29, 2020
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks David!

@original-brownbear original-brownbear merged commit bc63fa1 into elastic:master Jul 29, 2020
@original-brownbear original-brownbear deleted the 60332 branch July 29, 2020 07:20
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 29, 2020
Use real scope id from first available interface instead of `lo` which might
not exist on non-Linux platforms.

Closes elastic#60332
original-brownbear added a commit that referenced this pull request Jul 29, 2020
Use real scope id from first available interface instead of `lo` which might
not exist on non-Linux platforms.

Closes #60332
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 29, 2020
Follow up to elastic#60360, turns out at times the name of an interface that isn't loopback is not a valid scope id.
original-brownbear added a commit that referenced this pull request Jul 29, 2020
Follow up to #60360, turns out at times the name of an interface that isn't loopback is not a valid scope id.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 29, 2020
Follow up to elastic#60360, turns out at times the name of an interface that isn't loopback is not a valid scope id.
original-brownbear added a commit that referenced this pull request Jul 29, 2020
Follow up to #60360, turns out at times the name of an interface that isn't loopback is not a valid scope id.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations Team:Distributed Meta label for distributed team (obsolete) >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InetAddressesTest.testForStringIPv6WithScopeIdInput fails due with "no such interface lo"
4 participants