-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IPV6 Scope ID Test #60360
Merged
Merged
Fix IPV6 Scope ID Test #60360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use real scope id from first available interface instead of `lo` which might not exist on non-Linux platforms. Closes elastic#60332
original-brownbear
added
>test
Issues or PRs that are addressing/adding tests
:Distributed Coordination/Network
Http and internode communication implementations
v8.0.0
v7.10.0
labels
Jul 29, 2020
Pinging @elastic/es-distributed (:Distributed/Network) |
elasticmachine
added
the
Team:Distributed
Meta label for distributed team (obsolete)
label
Jul 29, 2020
DaveCTurner
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 29, 2020
Use real scope id from first available interface instead of `lo` which might not exist on non-Linux platforms. Closes elastic#60332
original-brownbear
added a commit
that referenced
this pull request
Jul 29, 2020
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 29, 2020
Follow up to elastic#60360, turns out at times the name of an interface that isn't loopback is not a valid scope id.
original-brownbear
added a commit
that referenced
this pull request
Jul 29, 2020
Follow up to #60360, turns out at times the name of an interface that isn't loopback is not a valid scope id.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 29, 2020
Follow up to elastic#60360, turns out at times the name of an interface that isn't loopback is not a valid scope id.
original-brownbear
added a commit
that referenced
this pull request
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Network
Http and internode communication implementations
Team:Distributed
Meta label for distributed team (obsolete)
>test
Issues or PRs that are addressing/adding tests
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use real scope id from first available interface instead of
lo
which mightnot exist on non-Linux platforms.
Closes #60332