-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce index based snapshot blob cache for Searchable Snapshots #60522
Merged
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
d001419
Introduce index based snapshot blob cache for Searchable Snapshots
tlrx c4f251c
WIP adjust some logging and back out cache-size-times-two optimisation
DaveCTurner 1f30c42
Avoid ActionListener#wrap
DaveCTurner 02a8ed1
Add TODO
DaveCTurner 76b97ab
Move special openInputStream impl
DaveCTurner df7c0b5
Add TODOs
DaveCTurner 922c381
Add TODOs
DaveCTurner c24d78e
Rework implementation
DaveCTurner 7e5bbc4
Merge branch 'master' into poc-blob-cache
DaveCTurner 1b459ae
One-shot reading
DaveCTurner f06e0ae
Try to fill the cache miss rather than immediately failing
DaveCTurner c5b65bc
No need for a list with <= 1 element
DaveCTurner 974c095
Reorder defs
DaveCTurner 2abf126
Mapping tweaks
DaveCTurner dad98d8
Merge branch 'master' into poc-blob-cache
DaveCTurner 4c8ed35
No need to index fields, we only get by ID
DaveCTurner 4b6798a
Comment
DaveCTurner 8a3b174
Rename
DaveCTurner 80e42ff
Assert no more indexing into cache after first startup
DaveCTurner b052d7e
Stronger assertions about what is read from the blob store when the c…
DaveCTurner d4919fa
No need for a fake blob store when we track accesses in the index inp…
DaveCTurner d2632ee
Assert no indexing at all after restart
DaveCTurner 4df37d6
Merge branch 'master' into poc-blob-cache
DaveCTurner 24f646f
Block test until cache fills are complete
DaveCTurner 5e752dd
Add debugging
DaveCTurner 5502545
Merge branch 'master' into poc-blob-cache
DaveCTurner 61701fe
Revert
DaveCTurner f5948c4
Moar revert
DaveCTurner 51a81ac
Revert
DaveCTurner 7116f9f
Revert buffer size increase
DaveCTurner 4b01c9a
Better assertion
DaveCTurner d3d58cd
Distinguish definite cache miss from cache-not-ready
DaveCTurner 0bcabe1
Precommit
DaveCTurner 43f281a
Test bug
DaveCTurner 78680be
Track reads from index cache too
DaveCTurner c50dfa6
Retry on INFE
DaveCTurner d6ef9cd
Always put a missing cache entry even if cache not ready
DaveCTurner 03a575e
Merge branch 'master' into poc-blob-cache
DaveCTurner 4f9584c
Let's keep indexing things for now
DaveCTurner cd77a43
Unnecessary repo
DaveCTurner 7aa25d0
Merge branch 'master' into poc-blob-cache
DaveCTurner 1c38aaa
Less allocation
DaveCTurner 0fbb71f
Use TransportActions.isShardNotAvailableException
DaveCTurner 7e6eb53
Always notify listener
DaveCTurner 6391d8f
Propagate direct exception directly to caller
DaveCTurner 7bd0e47
Also permit disconnected/not-connected/node-closed exceptions, and as…
DaveCTurner 60ceabb
Precommit
DaveCTurner b50d158
Check the cache index even after recovery complete
DaveCTurner d53443e
Collect timings for cache index reads
DaveCTurner 299443f
Assert enough space
DaveCTurner 8b607b0
Fix bytes-read stats
DaveCTurner dbf6f2f
Revert back to untimed counter
DaveCTurner e8bc561
Another revert to counter
DaveCTurner 1172e68
Avoid allocation reading cached blob
DaveCTurner 181b1f5
Allow waiting for a cache file range without committing to filling an…
DaveCTurner abdbf3c
No longer need to track whether recovery is done
DaveCTurner 38bf697
No need to wait for fetch threads to be idle
DaveCTurner 9fbf8ce
Delete restored index first to make sure it doesn't re-create the cac…
DaveCTurner ec9cd24
Remove test logging
DaveCTurner 1535e58
And another one
DaveCTurner 790bdc1
Merge branch 'master' into poc-blob-cache
DaveCTurner eb1a08e
Time out cache get after 5s
DaveCTurner deda305
Assert not blocking a SYSTEM_READ thread
DaveCTurner dad5dfd
Spotless
DaveCTurner 99045e0
Delimiters
DaveCTurner 2003ec0
Add stats to tests
DaveCTurner 62fe090
Catch exception during indexing
DaveCTurner 2c2a7c0
Remove duplicate assertion
DaveCTurner bb6d4ab
Another test needing cleanup
DaveCTurner 9e228c1
Account for 'any kind' reads from index cache
DaveCTurner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the
stats.yml
tests with the new fields?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ see 2003ec0