[ML] Update ML mappings upgrade test and extend to config index #61340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ML mappings upgrade test had become useless as it was checking a field that has been the same since 6.5. This commit switches to a field that was changed in 7.9. Additionally, the test only used to check the results index mappings. This commit also adds checking for the config index. Relates elastic#61157
droberts195
added
>test
|
Pinging @elastic/ml-core (:ml) |
| @@ -105,8 +120,40 @@ private void assertUpgradedMappings() throws Exception { | |||
| assertNotNull(propertiesLevel); | |||
| // TODO: as the years go by, the field we assert on here should be changed | |||
| // to the most recent field we've added that is NOT of type "keyword" | |||
| Map<String, Object> fieldLevel = (Map<String, Object>) propertiesLevel.get("multi_bucket_impact"); | |||
| assertEquals(Collections.singletonMap("type", "double"), fieldLevel); | |||
| Map<String, Object> objectLevel = (Map<String, Object>) propertiesLevel.get("model_size_stats"); | |||
There was a problem hiding this comment.
Could using XContentMapValues::extractValue method make this more concise?
There was a problem hiding this comment.
Yes, good point. I switched over to that.
|
|
||
| Map<String, Object> responseLevel = entityAsMap(response); | ||
| assertNotNull(responseLevel); | ||
| Map<String, Object> indexLevel = (Map<String, Object>) responseLevel.get(".ml-config"); |
There was a problem hiding this comment.
The same here, could XContentMapValues::extractValue be used instead of this sequence of gets and casts?
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Sep 2, 2020
The ML mappings upgrade test had become useless as it was checking a field that has been the same since 6.5. This commit switches to a field that was changed in 7.9. Additionally, the test only used to check the results index mappings. This commit also adds checking for the config index. Backport of elastic#61340
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Sep 2, 2020
The ML mappings upgrade test had become useless as it was checking a field that has been the same since 6.5. This commit switches to a field that was changed in 7.9. Additionally, the test only used to check the results index mappings. This commit also adds checking for the config index. Backport of elastic#61340
droberts195
added a commit
that referenced
this pull request
Sep 2, 2020
The ML mappings upgrade test had become useless as it was checking a field that has been the same since 6.5. This commit switches to a field that was changed in 7.9. Additionally, the test only used to check the results index mappings. This commit also adds checking for the config index. Backport of #61340
droberts195
added a commit
that referenced
this pull request
Sep 2, 2020
The ML mappings upgrade test had become useless as it was checking a field that has been the same since 6.5. This commit switches to a field that was changed in 7.9. Additionally, the test only used to check the results index mappings. This commit also adds checking for the config index. Backport of #61340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ML mappings upgrade test had become useless as it was
checking a field that has been the same since 6.5. This
commit switches to a field that was changed in 7.9.
Additionally, the test only used to check the results index
mappings. This commit also adds checking for the config
index.
Relates #61157