-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated threadpool for system index writes #61655
Dedicated threadpool for system index writes #61655
Conversation
This commit adds a dedicated threadpool for system index write operations. The dedicated resources for system index writes serves as a means to ensure that user activity does not block important system operations from occurring such as the management of users and roles.
Pinging @elastic/es-distributed (:Distributed/CRUD) |
You might want to force execution on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments, LGTM otherwise (no need for another round of review once the comments are addressed). You may want a second opinion from someone more familiar with this code though - write threadpools are not my area of expertise.
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/support/replication/TransportWriteAction.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionIngestTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I only looked at the indexing pressure stuff in bulk action and shard bulk action. If you wanted a full review from me, let me know.
This commit adds a dedicated threadpool for system index write operations. The dedicated resources for system index writes serves as a means to ensure that user activity does not block important system operations from occurring such as the management of users and roles. Backport of #61655
This commit adds a dedicated threadpool for system index write
operations. The dedicated resources for system index writes serves as
a means to ensure that user activity does not block important system
operations from occurring such as the management of users and roles.